Trace DNS resolution in reactor-netty #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
trask
reviewed
Nov 10, 2021
.../io/opentelemetry/javaagent/instrumentation/netty/v4_1/InstrumentedAddressResolverGroup.java
Show resolved
Hide resolved
Comment on lines
258
to
+259
| include(":instrumentation:netty:netty-4.1:javaagent") | ||
| include(":instrumentation:netty:netty-4.1-common:javaagent") |
There was a problem hiding this comment.
can netty-4.1-common:javaagent be merged into netty-4.1:javaagent and have reactor-netty:javaavent depend directly on netty-4.1:javaagent? or is there advantage to keeping it?
There was a problem hiding this comment.
Yes, it can! I don't know why I haven't thought of that 🙈
Done.
There was a problem hiding this comment.
I had to go back to the netty-4.1-common idea, muzzle failed when I merged that into the main 4.1 module:
MUZZLE PASSED io.opentelemetry.javaagent.instrumentation.netty.v4_1.NettyInstrumentationModule BUT FAILURE WAS EXPECTED
trask
reviewed
Nov 11, 2021
...ain/java/io/opentelemetry/javaagent/instrumentation/reactornetty/v1_0/ConnectionWrapper.java
Outdated
Show resolved
Hide resolved
...telemetry/javaagent/instrumentation/reactornetty/v1_0/TransportConnectorInstrumentation.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Nov 16, 2021
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Trace DNS resolution in reactor-netty * Code review comments * removed a little too much * implementation -> api * revert and make muzzle happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #4587