Fix http.url handing in vert.x 3 http client #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
anuraaga
reviewed
Nov 30, 2021
| @@ -78,6 +78,11 @@ class VertxHttpClientTest extends HttpClientTest<HttpClientRequest> implements A | |||
| false | |||
| } | |||
|
|
|||
| @Override | |||
| String nonRoutableAddress() { | |||
There was a problem hiding this comment.
Does it make sense to check testHttps instead of adding a similar knob?
...opentelemetry/javaagent/instrumentation/vertx/v3_0/client/HttpClientImplInstrumentation.java
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Nov 30, 2021
anuraaga
approved these changes
Dec 1, 2021
anuraaga
reviewed
Dec 1, 2021
...opentelemetry/javaagent/instrumentation/vertx/v3_0/client/Vertx3HttpAttributesExtractor.java
Outdated
Show resolved
Hide resolved
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Fix http.url handing in vert.x 3 http client * correct version * fix build * if https test is disabled use http for non routable aadress test * if https test is disabled use http for non routable aadress test * use StringBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4731