add rpc metrics conventions implement #4823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add rpc metrics conventions implement
yangtaoran
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
|
added 6 commits
December 7, 2021 17:04
fix AutoValue State
update RpcClientMetrics Visibility
update the filed serverDurationHistogram be final
|
thanks @yangtaoran! let us know if you are able to sign the CLA above |
update MetricsView doc
|
|
Hi @trask ,I have signed the CLA. |
|
hey @yangtaoran, it looks like the CLA check is failing on some of the commits because they are tied to a different email address (@qq.com). can you try squashing to a single commit tied to the email that you signed the CLA with (@gmail.com) and force pushing? hopefully that should resolve the CLA check, thx! |
add rpc metrics conventions implement fix AutoValue State fix AutoValue State update RpcClientMetrics Visibility update RpcClientMetrics Visibility update the filed serverDurationHistogram be final update the filed serverDurationHistogram be final update MetricsView code style update RpcClientMetrics code style update RpcServerMetrics code style update MetricsView doc update MetricsView doc
|
|
hi @yangtaoran, sorry about the CLA check, it looks like there are still commits in this PR that have author (@qq.com) which has not signed. it may be easier to close this PR and re-stage your changes as a single commit with author (@gmail.com) which has signed, and open a fresh PR. let us know if we can help. thx! |
|
hi @trask ,I'm sorry, I plan to close the PR and checkout a new branch to resubmit a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rpc metrics conventions implement