Fix some java lint warnings #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Jan 14, 2022
...on-api/src/main/java/io/opentelemetry/instrumentation/api/config/ConfigParsingException.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Jan 14, 2022
trask
approved these changes
Jan 14, 2022
Comment on lines
+24
to
+26
| // Because this module targets Java 9, we trigger this compiler bug which was fixed but not | ||
| // backported to Java 9 compilation. | ||
| // https://bugs.openjdk.java.net/browse/JDK-8209058 |
…nstrumentation into java-warnings
iNikem
reviewed
Jan 27, 2022
| @@ -30,13 +29,17 @@ | |||
| extends BaseTracer { | |||
| private static final String DB_QUERY = "DB Query"; | |||
|
|
|||
| protected final NetPeerAttributes netPeerAttributes; | |||
| protected final io.opentelemetry.instrumentation.api.tracer.net.NetPeerAttributes | |||
There was a problem hiding this comment.
Why this change, @anuraaga ?
There was a problem hiding this comment.
Since NetPeerAttributes is deprecated and can't be used in import statement
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Convert InstrumentationTestRunner from interface to abstract class * Foo * Commit * Revert unintended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into enabling lint on this repo like the others, for now sending a first set of lint fixes.
Depends on #5112