sun.net.www.protocol.http.HttpURLConnection.getOutputStream should tr…

instrumentation/http-url-connection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/GetOutputStreamContext.java

@@ -0,0 +1,60 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.javaagent.instrumentation.httpurlconnection;
+
+import static io.opentelemetry.context.ContextKey.named;
+
+import io.opentelemetry.context.Context;
+import io.opentelemetry.context.ContextKey;
+import io.opentelemetry.context.ImplicitContextKeyed;
+import java.net.HttpURLConnection;
+
+public class GetOutputStreamContext implements ImplicitContextKeyed {
+  private static final ContextKey<GetOutputStreamContext> KEY =
+      named("opentelemetry-http-url-connection-get-output-stream");
+
+  private volatile boolean outputStreamMethodOfSunConnectionCalled;
+
+  private GetOutputStreamContext() {}
+
+  @Override
+  public Context storeInContext(Context context) {
+    return context.with(KEY, this);
+  }
+
+  public static Context init(Context context) {
+    if (context.get(KEY) != null) {
+      return context;
+    }
+    return context.with(new GetOutputStreamContext());
+  }
+
+  public static GetOutputStreamContext get(Context context) {
+    return context.get(KEY);
+  }
+
+  public static void set(
+      Context context,
+      Class<? extends HttpURLConnection> connectionClass,
+      String methodName,
+      String requestMethod) {
+    GetOutputStreamContext getOutputStreamContext = context.get(KEY);
+    String connectionClassName = connectionClass.getName();
+    if ("sun.net.www.protocol.http.HttpURLConnection".equals(connectionClassName)
+        && "getOutputStream".equals(methodName)
+        && "POST"
+            .equals(
+                requestMethod) // To be sure that getOutputStream has transformed GET into POST if
+    // the method raised an exception
+    ) {
+      getOutputStreamContext.outputStreamMethodOfSunConnectionCalled = true;
+    }
+  }
+
+  public boolean isOutputStreamMethodOfSunConnectionCalled() {
+    return outputStreamMethodOfSunConnectionCalled;
+  }
+}

instrumentation/http-url-connection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/HttpMethodAttributeExtractor.java

@@ -0,0 +1,48 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.javaagent.instrumentation.httpurlconnection;
+
+import io.opentelemetry.api.common.AttributesBuilder;
+import io.opentelemetry.api.trace.Span;
+import io.opentelemetry.context.Context;
+import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
+import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
+import java.net.HttpURLConnection;
+import javax.annotation.Nullable;
+
+public class HttpMethodAttributeExtractor<
+        REQUEST extends HttpURLConnection, RESPONSE extends Integer>
+    implements AttributesExtractor<REQUEST, RESPONSE> {
+
+  private HttpMethodAttributeExtractor() {}
+
+  public static AttributesExtractor<? super HttpURLConnection, ? super Integer> create() {
+    return new HttpMethodAttributeExtractor<>();
+  }
+
+  @Override
+  public void onStart(
+      AttributesBuilder attributes, Context parentContext, HttpURLConnection connection) {}
+
+  @Override
+  public void onEnd(
+      AttributesBuilder attributes,
+      Context context,
+      HttpURLConnection connection,
+      @Nullable Integer responseCode,
+      @Nullable Throwable error) {
+
+    GetOutputStreamContext getOutputStreamContext = GetOutputStreamContext.get(context);
+
+    if (getOutputStreamContext.isOutputStreamMethodOfSunConnectionCalled()) {
+      String requestMethod = connection.getRequestMethod();
+      // The getOutputStream() has transformed "GET" into "POST"
+      attributes.put(SemanticAttributes.HTTP_METHOD, requestMethod);
+      Span span = Span.fromContext(context);
+      span.updateName("HTTP " + requestMethod);
+    }
+  }
+}

instrumentation/http-url-connection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/HttpUrlConnectionInstrumentation.java

@@ -116,6 +116,11 @@ public static void methodExit(
       callDepth.getAndIncrement();
       try {
         scope.close();
+        Class<? extends HttpURLConnection> connectionClass = connection.getClass();
+
+        String requestMethod = connection.getRequestMethod();
+        GetOutputStreamContext.set(
+            httpUrlState.context, connectionClass, methodName, requestMethod);
 
         if (throwable != null) {
           if (responseCode >= 400) {

instrumentation/http-url-connection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/HttpUrlConnectionSingletons.java

@@ -32,6 +32,10 @@ public final class HttpUrlConnectionSingletons {
             .addAttributesExtractor(HttpClientAttributesExtractor.create(httpAttributesGetter))
             .addAttributesExtractor(NetClientAttributesExtractor.create(netAttributesGetter))
             .addAttributesExtractor(PeerServiceAttributesExtractor.create(netAttributesGetter))
+            .addAttributesExtractor(HttpMethodAttributeExtractor.create())
+            .addContextCustomizer(
+                (context, httpRequestPacket, startAttributes) ->
+                    GetOutputStreamContext.init(context))
             .addOperationMetrics(HttpClientMetrics.get())
             .newClientInstrumenter(RequestPropertySetter.INSTANCE);
   }

instrumentation/http-url-connection/javaagent/src/test/groovy/HttpUrlConnectionTest.groovy

@@ -258,4 +258,69 @@ class HttpUrlConnectionTest extends HttpClientTest<HttpURLConnection> implements
       }
     }
   }
+
+  def "sun.net.www.protocol.http.HttpURLConnection.getOutputStream should transform GET into POST"() {
+    setup:
+    def url = resolveAddress("/success").toURL()
+    runWithSpan("someTrace") {
+
+      HttpURLConnection connection = url.openConnection()
+
+      def connectionClassName = connection.getClass().getName()
+
+      assert "sun.net.www.protocol.http.HttpURLConnection".equals(connectionClassName)
+
+      connection.setRequestMethod("GET")
+
+      String urlParameters = "q=ASDF&w=&e=&r=12345&t="
+
+      // Send POST request
+      connection.setDoOutput(true)
+      DataOutputStream wr = new DataOutputStream(connection.getOutputStream())
+      wr.writeBytes(urlParameters)
+      wr.flush()
+      wr.close()
+
+      assert connection.getResponseCode() == STATUS
+
+      def stream = connection.inputStream
+      def lines = stream.readLines()
+      stream.close()
+      assert lines == [RESPONSE]
+    }
+
+    expect:
+    assertTraces(1) {
+      trace(0, 3) {
+        span(0) {
+          name "someTrace"
+          hasNoParent()
+          attributes {
+          }
+        }
+        span(1) {
+          name "HTTP POST"
+          kind CLIENT
+          childOf span(0)
+          attributes {
+            "$SemanticAttributes.NET_TRANSPORT" IP_TCP
+            "$SemanticAttributes.NET_PEER_NAME" "localhost"
+            "$SemanticAttributes.NET_PEER_PORT" server.httpPort()
+            "$SemanticAttributes.HTTP_URL" "$url"
+            "$SemanticAttributes.HTTP_METHOD" "POST"
+            "$SemanticAttributes.HTTP_STATUS_CODE" STATUS
+            "$SemanticAttributes.HTTP_FLAVOR" "1.1"
+          }
+        }
+        span(2) {
+          name "test-http-server"
+          kind SERVER
+          childOf span(1)
+          attributes {
+          }
+        }
+      }
+    }
+  }
+
 }