Add code attributes to several instrumentations #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Jul 25, 2022
mateuszrzeszutek
force-pushed
the
code-attributes
branch
from
5581127
to
19219c6
Compare
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
* Add code attributes to several instrumentations * fix servlet tests * fix tests * fix elasticsearch tests * fix context bridge test * fix rxjava tests * fix spring webmvc tests
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
* Add code attributes to several instrumentations * fix servlet tests * fix tests * fix elasticsearch tests * fix context bridge test * fix rxjava tests * fix spring webmvc tests
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
* Add code attributes to several instrumentations * fix servlet tests * fix tests * fix elasticsearch tests * fix context bridge test * fix rxjava tests * fix spring webmvc tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... that'd otherwise create spans with no attributes at all; in particular the
@WithSpanand configured methods instrumentations.