Add gradle plugin for SDK extensions #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Sep 8, 2022
| plugins { | ||
| id("io.opentelemetry.instrumentation.library-instrumentation") | ||
|
|
||
| id("otel.jacoco-conventions") |
There was a problem hiding this comment.
Since we don't publish the jacoco reports maybe we shouldn't use it at all?
There was a problem hiding this comment.
Hm, I suppose that'd make sense.
I think there's a broader question of what we want to do with jacoco in general, cause it's currently being included in several gradle plugins (including the library instrumentation one), and we're not doing anything with that.
laurit
approved these changes
Sep 8, 2022
trask
approved these changes
Sep 8, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6534
I didn't really have any good idea on how to name it, I called it
otel.sdk-extension(since that was the name for this kind of modules in the SDK repo).