-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource providers #6574
Add resource providers #6574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this PR gets merged (in its current shape), the agent will still depend on the old resource modules, and these new resource providers will not be included in it by default -- and I'm completely fine with that, we can change that in the next PR, I just wanted to state that openly so that we're all on the same page here.
...src/main/resources/META-INF/services/io.opentelemetry.sdk.autoconfigure.spi.ResourceProvider
Outdated
Show resolved
Hide resolved
Yes I was planning on doing that in a followup. Happy to do it in this PR to if you prefer. |
@jack-berg I maybe didn't follow, any reason not to include in 1.18.0? |
Only reason to hold off might be so there aren't two undeprecated versions of these resource providers published in 1.18.0. I.e. I don't feel strongly about this though. Can also merge with a flag that disabled publishing until post release. |
got it, thx, that makes sense, will hold on this until after 1.18.0 release |
* Add resource providers * Use autoservice annotation
* Add resource providers * Use autoservice annotation
* Add resource providers * Use autoservice annotation
Related to #4701.
Note, if merged as is this will publish with 1.18.0. Perhaps we should wait until 1.19.0?
Also, this artifact was stable in
opentelemetry-java
but is currently alpha here. We should discuss whether we want to mark it as stable.