Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource providers #6574

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

jack-berg
Copy link
Member

Related to #4701.

Note, if merged as is this will publish with 1.18.0. Perhaps we should wait until 1.19.0?

Also, this artifact was stable in opentelemetry-java but is currently alpha here. We should discuss whether we want to mark it as stable.

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this PR gets merged (in its current shape), the agent will still depend on the old resource modules, and these new resource providers will not be included in it by default -- and I'm completely fine with that, we can change that in the next PR, I just wanted to state that openly so that we're all on the same page here.

@jack-berg
Copy link
Member Author

After this PR gets merged (in its current shape), the agent will still depend on the old resource modules, and these new resource providers will not be included in it by default

Yes I was planning on doing that in a followup. Happy to do it in this PR to if you prefer.

@trask
Copy link
Member

trask commented Sep 12, 2022

@jack-berg I maybe didn't follow, any reason not to include in 1.18.0?

@jack-berg
Copy link
Member Author

Only reason to hold off might be so there aren't two undeprecated versions of these resource providers published in 1.18.0. I.e. io.opentelemetry:opentelemetry-sdk-extension-resources:1.18.0 and io.opentelemetry.instrumentation:opentelemetry-resources:1.18.0-alpha would both have the same code and both be undeprecated.

I don't feel strongly about this though. Can also merge with a flag that disabled publishing until post release.

@trask
Copy link
Member

trask commented Sep 12, 2022

got it, thx, that makes sense, will hold on this until after 1.18.0 release

@trask trask merged commit 6b607c1 into open-telemetry:main Sep 14, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
* Add resource providers

* Use autoservice annotation
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
* Add resource providers

* Use autoservice annotation
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
* Add resource providers

* Use autoservice annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants