Fix logback appender latest deps test failure #6608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx for sending this, I saw the Java 18 failure below and assumed it was due to the logback test (but it's just a flaky maven download), otherwise I would have merged it earlier. anyways I wanted to convert the logback test to Java anyways, so sent #6613 in the meantime |
|
Closing in favour of #6613 I suspect that the unexpected values for code.function/code.namespace are some kind of groovy oddity which are resolved by converting the test to java. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this gets the latest deps test passing. This could use assertions for the expected attributes. The not latest deps configuration reports
code.function="call", code.namespace="org.slf4j.Logger$info"which isn't probably what it should reprot.