Temporarily limit instrumentation to exclude Spring 6 #7202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
Closed
jack-berg
approved these changes
Nov 16, 2022
trask
added a commit
that referenced
this pull request
Jan 12, 2023
Related to #7107 and #7202 Support WebFlux 6. Supporting reactor 3.5 seems pretty straightforward, the `subscriberContext()` was deprecated in 3.4 in favor of `contextWrite()`. In 3.5, `subscriberContext()` was removed. This PR doesn't bump `latestDepTestLibrary` to 3.5 yet because there are a couple of tests that succeed in 3.4 using `contextWrite()` but fail in 3.5 using `contextWrite()`. My proposal is to review/merge this PR, and then I can ping our resident reactor experts to see if they have thoughts on the failing tests in 3.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue to support Spring 6 #7203