Make Advice proper immutable class

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
open-telemetry · Jun 13, 2023 · 0bed21f · 0bed21f
1 parent ac0b4e4
commit 0bed21f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/descriptor/Advice.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/descriptor/Advice.java
@@ -6,6 +6,8 @@
 package io.opentelemetry.sdk.metrics.internal.descriptor;
 
 import com.google.auto.value.AutoValue;
+import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import javax.annotation.Nullable;
 import javax.annotation.concurrent.Immutable;
@@ -21,6 +23,10 @@ public static Advice empty() {
   }
 
   public static Advice create(@Nullable List<Double> explicitBucketBoundaries) {
+    if (explicitBucketBoundaries != null) {
+      explicitBucketBoundaries =
+          Collections.unmodifiableList(new ArrayList<>(explicitBucketBoundaries));
+    }
     return new AutoValue_Advice(explicitBucketBoundaries);
   }