address review comments

open-telemetry · Oct 10, 2023 · a1563a6 · a1563a6
1 parent a372bf5
commit a1563a6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/InstrumentBuilder.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/InstrumentBuilder.java
@@ -39,7 +39,6 @@ final class InstrumentBuilder {
 
   public void setUnit(String unit) {
     descriptor.setUnit(unit);
-    ;
   }
 
   public void setDescription(String description) {

diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleGauge.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleGauge.java
@@ -51,6 +51,7 @@ static final class SdkDoubleGaugeBuilder
 
       MutableInstrumentDescriptor descriptor =
           MutableInstrumentDescriptor.create(
+              // TODO: use InstrumentType.GAUGE when available
               name, InstrumentType.OBSERVABLE_GAUGE, InstrumentValueType.DOUBLE);
       builder = new InstrumentBuilder(meterProviderSharedState, meterSharedState, descriptor);
     }