Should I commit files that changed after running ./gradle jApiCmp #6561
Answered
by
jkwatson
hongshuai1994
asked this question in
Q&A
-
|
I am trying to submit a PR, but some Checks have not passed. Check the Checks error content. The prompts are as follows. |
Beta Was this translation helpful? Give feedback.
Answered by
jkwatson
Jul 8, 2024
Replies: 1 comment
-
|
yes, those need to be submitted as a part of PRs, normally. However, we're in the middle of getting our post-release automation straightened out, which should get the diff docs up to date. So, unless you're changing the public APIs, it shouldn't be necessary to include them in the PR. |
Beta Was this translation helpful? Give feedback.
0 replies
Answer selected by
hongshuai1994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
yes, those need to be submitted as a part of PRs, normally. However, we're in the middle of getting our post-release automation straightened out, which should get the diff docs up to date. So, unless you're changing the public APIs, it shouldn't be necessary to include them in the PR.