Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin remoteEndpoint is missing #4932

Closed
jonatan-ivanov opened this issue Nov 10, 2022 · 0 comments · Fixed by #4933
Closed

Zipkin remoteEndpoint is missing #4932

jonatan-ivanov opened this issue Nov 10, 2022 · 0 comments · Fixed by #4933
Labels
Bug Something isn't working

Comments

@jonatan-ivanov
Copy link
Member

The Zipkin Data Model has a remoteEndpoint field that is used by Zipkin and it has effect on the span visualization.
According to the OTel docs, peer.service should be used for this purpose but according to the codebase it is not used and remoteEndpoint is never set.

Originally reported (here) on CNCF Slack.

Steps to reproduce
Send a span to Zipkin (peer.service should be set).

What did you expect to see?
remoteEndpoint being populated.

What did you see instead?
remoteEndpoint is missing.

What version and what artifacts are you using?
zipkin-exporter
Version: latest (main)

Environment
Unrelated.
@jonatan-ivanov jonatan-ivanov added the Bug Something isn't working label Nov 10, 2022
jonatan-ivanov added a commit to jonatan-ivanov/opentelemetry-java that referenced this issue Nov 10, 2022
@jonatan-ivanov
Populate Zipkin remoteEndpoint
5855a24 
fixes open-telemetrygh-4932
@jonatan-ivanov jonatan-ivanov mentioned this issue Nov 10, 2022
Merged
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this issue Dec 30, 2022
@jonatan-ivanov @dmarkwat
Populate Zipkin remoteEndpoint (open-telemetry#4933)
2afda4f 
* Populate Zipkin remoteEndpoint
fixes open-telemetrygh-4932

* Add conditions for creating zipkin remote endpoint

* Parameterize remote endpoint tests with span kind

* Verify INTERNAL span kind too
@jonatan-ivanov jonatan-ivanov mentioned this issue Jun 15, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Populate Zipkin remoteEndpoint jonatan-ivanov/opentelemetry-java
1 participant
@jonatan-ivanov