Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleLogProcessor #3749

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

jack-berg
Copy link
Member

As I was prototyping a Log4j2 OpenTelemetryAppender, I found testing inconvenient without a SimpleLogProcessor.

The primary use case of SimpleSpanProcessor is to use with the logging exporters. Logs won't have that use case as often, since application logs may be fed through the span processor, resulting in a cycle if they're logged out again. However I still think its useful to have this for: 1. testing. 2. for use cases where applications use the logging sdk to record things that are closer to "events" than application logs.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #3749 (76edecb) into main (9b9dcf9) will increase coverage by 0.06%.
The diff coverage is 82.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3749      +/-   ##
============================================
+ Coverage     89.21%   89.27%   +0.06%     
- Complexity     3877     3889      +12     
============================================
  Files           464      465       +1     
  Lines         12136    12171      +35     
  Branches       1189     1190       +1     
============================================
+ Hits          10827    10866      +39     
+ Misses          916      913       -3     
+ Partials        393      392       -1     
Impacted Files Coverage Δ
...ntelemetry/sdk/logs/export/SimpleLogProcessor.java 82.85% <82.85%> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 90.78% <0.00%> (+0.70%) ⬆️
...ntelemetry/sdk/extension/resources/OsResource.java 90.69% <0.00%> (+4.65%) ⬆️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️
...metry/sdk/extension/resources/ProcessResource.java 87.50% <0.00%> (+6.25%) ⬆️
...elemetry/sdk/extension/resources/HostResource.java 92.30% <0.00%> (+15.38%) ⬆️
...dk/extension/resources/ProcessRuntimeResource.java 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b9dcf9...76edecb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants