Remove supported temporality #3939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
requested review from
anuraaga,
bogdandrutu,
carlosalberto,
jkwatson and
jsuereth
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3939 +/- ##
============================================
+ Coverage 89.71% 89.79% +0.07%
+ Complexity 4170 4166 -4
============================================
Files 498 498
Lines 12661 12646 -15
Branches 1223 1221 -2
============================================
- Hits 11359 11355 -4
+ Misses 908 900 -8
+ Partials 394 391 -3
Continue to review full report at Codecov.
|
jkwatson
reviewed
Nov 29, 2021
| EnumSet<AggregationTemporality> supported, @Nullable AggregationTemporality preferred) { | ||
| // Next assume preferred should always win. | ||
| static AggregationTemporality resolveTemporality(@Nullable AggregationTemporality preferred) { | ||
| // If preferred temporality is provided respect it | ||
| if (preferred != null) { | ||
| return preferred; |
There was a problem hiding this comment.
we could just do a simple one-liner for this whole method now, right?
return preferred == null ? AggregationTemporality.CUMULATIVE : preferred;
jkwatson
approved these changes
Nov 29, 2021
anuraaga
approved these changes
Nov 30, 2021
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per recent change to the spec.