Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate log name field #4160

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Conversation

jack-berg
Copy link
Member

The log name has been removed from the spec and is being deprecated from the proto.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #4160 (4ffe66d) into main (b9074f1) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4160      +/-   ##
============================================
+ Coverage     90.23%   90.29%   +0.05%     
- Complexity     4599     4611      +12     
============================================
  Files           537      537              
  Lines         14082    14100      +18     
  Branches       1347     1348       +1     
============================================
+ Hits          12707    12731      +24     
+ Misses          933      926       -7     
- Partials        442      443       +1     
Impacted Files Coverage Δ
...etry/exporter/internal/otlp/logs/LogMarshaler.java 69.62% <ø> (ø)
...entelemetry/sdk/testing/assertj/LogDataAssert.java 100.00% <ø> (ø)
.../java/io/opentelemetry/sdk/logs/SdkLogBuilder.java 100.00% <ø> (ø)
...io/opentelemetry/sdk/logs/data/LogDataBuilder.java 100.00% <ø> (ø)
...va/io/opentelemetry/sdk/logs/data/LogDataImpl.java 100.00% <ø> (ø)
...sdk/autoconfigure/MetricExporterConfiguration.java 84.72% <0.00%> (-2.43%) ⬇️
...rc/main/java/io/opentelemetry/context/Context.java 100.00% <0.00%> (ø)
...io/opentelemetry/sdk/metrics/SdkMeterProvider.java 92.30% <0.00%> (+3.07%) ⬆️
...emetry/api/baggage/propagation/PercentEscaper.java 84.21% <0.00%> (+4.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9074f1...4ffe66d. Read the comment docs.

@@ -86,6 +86,7 @@ public LogDataBuilder setSeverityText(String severityText) {
}

/** Set the name. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to document the deprecation in javadoc and explain that it will be removed with no replacement.

@anuraaga anuraaga merged commit 19b0fec into open-telemetry:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants