Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument type temporality #4288

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Mar 21, 2022

Partially implements spec PR #2404.

  • Add AggregationTemporality getAggregationTemporality(InstrumentType) to MetricReader / MetricExporter, replaces AggregationTemporality getPreferredTemporality().
  • Does NOT add the newly specified ability for MetricReader to dictate default aggregation via Aggregation getAggregation(InstrumentType). Can add that in a followup PR, and potentially after 1.13.0.
  • Changes OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY to OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE, with backwards compatibility until post 1.13.0

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #4288 (4fce5f3) into main (c4ea1c1) will increase coverage by 0.03%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main    #4288      +/-   ##
============================================
+ Coverage     89.88%   89.91%   +0.03%     
- Complexity     4844     4845       +1     
============================================
  Files           568      567       -1     
  Lines         15063    15075      +12     
  Branches       1427     1430       +3     
============================================
+ Hits          13539    13555      +16     
+ Misses         1060     1055       -5     
- Partials        464      465       +1     
Impacted Files Coverage Δ
...entelemetry/sdk/metrics/export/MetricExporter.java 100.00% <ø> (ø)
...lp/http/metrics/OtlpHttpMetricExporterBuilder.java 93.75% <71.42%> (-6.25%) ⬇️
...er/otlp/metrics/OtlpGrpcMetricExporterBuilder.java 89.47% <71.42%> (-4.82%) ⬇️
...er/logging/otlp/OtlpJsonLoggingMetricExporter.java 85.71% <80.00%> (-4.29%) ⬇️
...emetry/exporter/logging/LoggingMetricExporter.java 79.16% <80.00%> (-3.45%) ⬇️
...rter/otlp/http/metrics/OtlpHttpMetricExporter.java 90.90% <100.00%> (ø)
...lemetry/exporter/internal/ExporterBuilderUtil.java 100.00% <100.00%> (ø)
.../exporter/otlp/metrics/OtlpGrpcMetricExporter.java 81.81% <100.00%> (ø)
...etry/exporter/prometheus/PrometheusHttpServer.java 78.72% <100.00%> (+5.03%) ⬆️
...sshim/metrics/OpenCensusAttachingMetricReader.java 75.00% <100.00%> (-2.78%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ea1c1...4fce5f3. Read the comment docs.

@jack-berg jack-berg force-pushed the instrument-type-temporality branch from 72f4788 to a8547b3 Compare March 22, 2022 18:44
@jack-berg jack-berg marked this pull request as ready for review March 22, 2022 18:45
@jack-berg jack-berg requested a review from a user March 22, 2022 18:45
@jack-berg jack-berg requested a review from Oberon00 as a code owner March 22, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants