Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Data from metric assertion class names #4433

Merged
merged 1 commit into from
May 5, 2022

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented May 3, 2022

Trace assertions have some mix of Data or not on whether there is a corresponding SDK class for it, but this isn't really very helpful. An assertion is an assertion and there's not much need for the word - for metrics we can clean up a bit

@anuraaga anuraaga requested a review from a user May 3, 2022 06:44
@anuraaga anuraaga requested a review from Oberon00 as a code owner May 3, 2022 06:44
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #4433 (0c14d9e) into main (4a2814b) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4433      +/-   ##
============================================
+ Coverage     90.00%   90.05%   +0.05%     
- Complexity     4885     4927      +42     
============================================
  Files           563      567       +4     
  Lines         15159    15278     +119     
  Branches       1459     1472      +13     
============================================
+ Hits          13644    13759     +115     
- Misses         1044     1048       +4     
  Partials        471      471              
Impacted Files Coverage Δ
...metry/sdk/testing/assertj/AbstractPointAssert.java 100.00% <ø> (ø)
...etry/sdk/testing/assertj/HistogramPointAssert.java 85.18% <ø> (ø)
...emetry/sdk/testing/assertj/SummaryPointAssert.java 100.00% <ø> (ø)
...lemetry/sdk/testing/assertj/DoubleGaugeAssert.java 100.00% <100.00%> (ø)
...lemetry/sdk/testing/assertj/DoublePointAssert.java 100.00% <100.00%> (ø)
...telemetry/sdk/testing/assertj/DoubleSumAssert.java 100.00% <100.00%> (ø)
...telemetry/sdk/testing/assertj/LongGaugeAssert.java 100.00% <100.00%> (ø)
...telemetry/sdk/testing/assertj/LongPointAssert.java 80.00% <100.00%> (ø)
...entelemetry/sdk/testing/assertj/LongSumAssert.java 100.00% <100.00%> (ø)
...pentelemetry/sdk/testing/assertj/MetricAssert.java 95.23% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2814b...0c14d9e. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change.

@jack-berg jack-berg merged commit bfb39f4 into open-telemetry:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants