Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to semantic conventions version 1.13.0 #4766

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

jkwatson
Copy link
Contributor

No description provided.

@jkwatson jkwatson requested a review from a team September 20, 2022 03:55
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 90.77% // Head: 90.78% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1fcc657) compared to base (064f246).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4766   +/-   ##
=========================================
  Coverage     90.77%   90.78%           
- Complexity     4817     4835   +18     
=========================================
  Files           551      554    +3     
  Lines         14364    14415   +51     
  Branches       1397     1399    +2     
=========================================
+ Hits          13039    13086   +47     
- Misses          909      910    +1     
- Partials        416      419    +3     
Impacted Files Coverage Δ
...emconv/resource/attributes/ResourceAttributes.java 100.00% <100.00%> (ø)
...main/java/io/opentelemetry/sdk/logs/SdkLogger.java 90.00% <0.00%> (-10.00%) ⬇️
...va/io/opentelemetry/sdk/logs/SdkLoggerBuilder.java 100.00% <0.00%> (ø)
...a/io/opentelemetry/sdk/logs/SdkLoggerProvider.java 100.00% <0.00%> (ø)
...io/opentelemetry/sdk/logs/SdkLogRecordBuilder.java 97.36% <0.00%> (ø)
...entelemetry/sdk/logs/SdkLoggerProviderBuilder.java 100.00% <0.00%> (ø)
...opentelemetry/opentracingshim/SpanBuilderShim.java 77.89% <0.00%> (ø)
...pentelemetry/opentracingshim/ScopeManagerShim.java 94.44% <0.00%> (ø)
...etry/exporter/internal/otlp/logs/LogMarshaler.java 68.42% <0.00%> (ø)
...autoconfigure/spi/AutoConfigurationCustomizer.java 0.00% <0.00%> (ø)
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines -1114 to -1117
/** Another IP-based protocol. */
public static final String IP = "ip";
/** Unix Domain socket. See below. */
public static final String UNIX = "unix";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the removal of these is a non-backwards compatible breaking change. Not sure what we should do about it, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could modify the generator around the lines 87-88 so that it'd detect if it's about to output NetTransportValues and if so, add these two deprecated values as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you ok with adding this as a followup? I'm not sure I see exactly how this would work (my jinja skills are very poor).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind. I figured it out. added them as deprecated here.

* @deprecated this item has been removed as of 1.13.0 of the semantic conventions. Please use {@link SemanticAttributes#HTTP_REQUEST_CONTENT_LENGTH} instead.
*/
@Deprecated
public static final AttributeKey<Long> HTTP_REQUEST_CONTENT_LENGTH_UNCOMPRESSED =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's several more of those:

  • HTTP_RESPONSE_CONTENT_LENGTH_UNCOMPRESSED
  • HTTP_HOST
  • NET_PEER_IP
  • NET_PEER_PORT
  • NET_HOST_IP

Can you add these as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is our general practice to retain deleted attributes with @Deprecated for a single release cycle, indefinitely, some other schedule?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question -- I think a single release cycle is fine, it lets whoever's using the lib replace those deprecated usages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, although NET_PEER_PORT is still here. updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like HTTP_RESPONSE_CONTENT_LENGTH_UNCOMPRESSED is still missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops. missed request vs. response. added.

Comment on lines -1114 to -1117
/** Another IP-based protocol. */
public static final String IP = "ip";
/** Unix Domain socket. See below. */
public static final String UNIX = "unix";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could modify the generator around the lines 87-88 so that it'd detect if it's about to output NetTransportValues and if so, add these two deprecated values as well.

@mateuszrzeszutek mateuszrzeszutek linked an issue Sep 21, 2022 that may be closed by this pull request
@jkwatson jkwatson merged commit 3456e6b into open-telemetry:main Sep 30, 2022
@jkwatson jkwatson deleted the update_semconv_1_13 branch September 30, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SemanticAttributes class is outdated
3 participants