Add User-Agent header to OTLP exporter requests #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.78% // Head: 90.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4784 +/- ##
============================================
+ Coverage 90.78% 90.84% +0.05%
- Complexity 4822 4856 +34
============================================
Files 554 556 +2
Lines 14383 14474 +91
Branches 1397 1410 +13
============================================
+ Hits 13058 13149 +91
+ Misses 909 908 -1
- Partials 416 417 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
trask
reviewed
Sep 26, 2022
.../io/opentelemetry/exporter/otlp/testing/internal/ManagedChannelTelemetryExporterBuilder.java
Outdated
Show resolved
Hide resolved
...ers/otlp/common/src/test/java/io/opentelemetry/exporter/internal/otlp/OtlpUserAgentTest.java
Outdated
Show resolved
Hide resolved
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/OtlpUserAgent.java
Outdated
Show resolved
Hide resolved
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/OtlpUserAgent.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/exporter/otlp/testing/internal/AbstractGrpcTelemetryExporterTest.java
Outdated
Show resolved
Hide resolved
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/OtlpUserAgent.java
Outdated
Show resolved
Hide resolved
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/OtlpUserAgent.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Oct 3, 2022
mateuszrzeszutek
approved these changes
Oct 4, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@jkwatson please take a look when you have a chance |
jkwatson
reviewed
Oct 18, 2022
| @@ -9,7 +9,7 @@ plugins { | |||
| } | |||
|
|
|||
| description = "OpenTelemetry Protocol Exporter" | |||
| otelJava.moduleName.set("io.opentelemetry.exporter.otlp.internal") | |||
| otelJava.moduleName.set("io.opentelemetry.exporter.internal.otlp") | |||
There was a problem hiding this comment.
what affect does this have?
There was a problem hiding this comment.
The moduleName is used to set the location of the version.properties file. It should reflect the base package of the artifact, so in this case it was wrong. If its not correct, then fetching a relative resource like OtlpUserAgent.class.getResourceAsStream("version.properties") will fail.
jkwatson
reviewed
Oct 18, 2022
.../io/opentelemetry/exporter/otlp/testing/internal/ManagedChannelTelemetryExporterBuilder.java
Show resolved
Hide resolved
jkwatson
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements spec PR #2684.