Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BatchLogRecordProcessor autoconfiguration #4811

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

jack-berg
Copy link
Member

Implements spec PR #2785.

@jack-berg jack-berg requested a review from a team September 30, 2022 18:44
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 90.77% // Head: 90.80% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (f663266) compared to base (e4ee76b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4811      +/-   ##
============================================
+ Coverage     90.77%   90.80%   +0.02%     
- Complexity     4835     4842       +7     
============================================
  Files           554      554              
  Lines         14414    14427      +13     
  Branches       1399     1403       +4     
============================================
+ Hits          13085    13100      +15     
+ Misses          910      907       -3     
- Partials        419      420       +1     
Impacted Files Coverage Δ
...sdk/autoconfigure/LoggerProviderConfiguration.java 95.00% <100.00%> (+2.40%) ⬆️
...metry/sdk/metrics/export/PeriodicMetricReader.java 87.14% <0.00%> (-2.86%) ⬇️
...dk/logs/export/BatchLogRecordProcessorBuilder.java 96.96% <0.00%> (+12.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@jack-berg
Copy link
Member Author

@jkwatson please take a look when you have the chance


| System property | Environment variable | Description |
|---------------------------------|---------------------------------|------------------------------------------------------------------------------------|
| otel.blrp.schedule.delay | OTEL_BLRP_SCHEDULE_DELAY | The interval, in milliseconds, between two consecutive exports. Default is `5000`. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm never going to be able to see this without yelling "BLURP!"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe "BLORP!"

@jack-berg jack-berg merged commit 99dbcaf into main Oct 17, 2022
@jack-berg jack-berg deleted the blrp-autoconfigure branch October 17, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants