-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toString method to AbstractInstrument #4883
Add toString method to AbstractInstrument #4883
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me
666aaf3
to
05cac6e
Compare
|
05cac6e
to
6591edd
Compare
force push to the branch with author e-mail change |
Codecov ReportBase: 90.79% // Head: 90.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4883 +/- ##
============================================
+ Coverage 90.79% 90.83% +0.04%
- Complexity 4844 4857 +13
============================================
Files 555 556 +1
Lines 14438 14475 +37
Branches 1405 1410 +5
============================================
+ Hits 13109 13149 +40
+ Misses 910 908 -2
+ Partials 419 418 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Partially resolves: #4829
I have added a
toString
method to the abstract class to make it available for every implementation of the AbstractInstrument. I believe the better way would be adding toString method to each the subclasses, but I would appreciate a piece of advice here.Sample toString for the SdkDoubleHistogram is: