Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make description of Samplers Locale independent #4887

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

lmonkiewicz
Copy link
Contributor

Fixes: #4880

@lmonkiewicz lmonkiewicz requested a review from a team October 26, 2022 11:02
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 90.83% // Head: 90.83% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0a477da) compared to base (a46dd00).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4887      +/-   ##
============================================
- Coverage     90.83%   90.83%   -0.01%     
- Complexity     4856     4859       +3     
============================================
  Files           556      556              
  Lines         14474    14483       +9     
  Branches       1410     1410              
============================================
+ Hits          13148    13155       +7     
- Misses          908      909       +1     
- Partials        418      419       +1     
Impacted Files Coverage Δ
...sion/trace/jaeger/sampler/RateLimitingSampler.java 88.88% <100.00%> (+3.17%) ⬆️
...y/sdk/trace/samplers/TraceIdRatioBasedSampler.java 86.66% <100.00%> (+2.05%) ⬆️
...metry/sdk/metrics/export/PeriodicMetricReader.java 87.14% <0.00%> (-2.86%) ⬇️
.../opentelemetry/sdk/metrics/AbstractInstrument.java 41.66% <0.00%> (+5.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment. Thanks!

@lmonkiewicz
Copy link
Contributor Author

Just one small comment. Thanks!

Changed.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jack-berg what do you think about calculating it once in the constructor? getDescription is not supposed to be called a lot, but just in case...

and I think the extra small amount of memory is ok since there shouldn't be a huge number of Sampler instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samplers use Locale dependent formatting for description
4 participants