Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OT Shim: Use 'opentracing-shim' as instrumentation scope name. #4890

Merged

Conversation

carlosalberto
Copy link
Contributor

This matches the expected name from the related Spec section.

@carlosalberto carlosalberto requested a review from a team October 26, 2022 20:11
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 90.83% // Head: 90.83% // No change to project coverage 👍

Coverage data is based on head (4165e3e) compared to base (21d5597).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4890   +/-   ##
=========================================
  Coverage     90.83%   90.83%           
  Complexity     4857     4857           
=========================================
  Files           556      556           
  Lines         14475    14475           
  Branches       1410     1410           
=========================================
  Hits          13149    13149           
  Misses          908      908           
  Partials        418      418           
Impacted Files Coverage Δ
...opentelemetry/opentracingshim/OpenTracingShim.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 435411b into open-telemetry:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants