-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTracing Shim: Full multiple parent support. #4916
OpenTracing Shim: Full multiple parent support. #4916
Conversation
This includes: * The Baggage union of ALL parents is used. * All parents are added as Links, in order to preserve the OpenTracing reference type as an attribute (either CHILD_OF or FOLLOWS_FROM).
Codecov ReportBase: 90.83% // Head: 90.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4916 +/- ##
============================================
+ Coverage 90.83% 90.98% +0.14%
+ Complexity 4857 4830 -27
============================================
Files 556 545 -11
Lines 14475 14415 -60
Branches 1410 1388 -22
============================================
- Hits 13149 13116 -33
+ Misses 908 895 -13
+ Partials 418 404 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor suggestions but looks good
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java
Show resolved
Hide resolved
…m/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
…m/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
…m/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
Thanks for the review @jack-berg - applied the feedback. The only remaining item is the |
opentracing-shim/src/test/java/io/opentelemetry/opentracingshim/SpanBuilderShimTest.java
Show resolved
Hide resolved
* Full multiple parent support. This includes: * The Baggage union of ALL parents is used. * All parents are added as Links, in order to preserve the OpenTracing reference type as an attribute (either CHILD_OF or FOLLOWS_FROM). * Update opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> * Update opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> * Update opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> * Apply feedback. * More feedback. Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
This includes:
Fixes #4906
Fixes #4907