-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EC mTLS keys #4920
Conversation
...n-tests/otlp/src/main/java/io/opentelemetry/integrationtest/OtlpExporterIntegrationTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 90.90% // Head: 91.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4920 +/- ##
============================================
+ Coverage 90.90% 91.05% +0.14%
- Complexity 4803 4808 +5
============================================
Files 545 544 -1
Lines 14340 14318 -22
Branches 1383 1367 -16
============================================
+ Hits 13036 13037 +1
+ Misses 897 884 -13
+ Partials 407 397 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
exporters/common/src/main/java/io/opentelemetry/exporter/internal/TlsUtil.java
Show resolved
Hide resolved
@jkwatson take a look when you have a chance. Would be good to get this in for the next release. |
Can I know when is the next release? |
We try to release the end of the first week of the month. |
* Add support for EC mTlS keys * Revert change to integration test
Resolves #4918.
This adds support for EC mTLS keys in addition to the currently supported RSA keys. The tricky bit is determining which algorithm type the key is, and therefore which
KeyFactory
to use to generate the private key. Bouncy castle apparently has a decent way to do this, but we should try to do it without additional dependencies if possible. The strategy I've taken in this PR is to create a list of supported algorithms, and determine which the key corresponds to by iterating through them and trying generate a private key with a try / catch.