Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTracing Shim: Properly set the status based on the error tag. #4962

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

carlosalberto
Copy link
Contributor

Fixes #4910

@carlosalberto carlosalberto requested a review from a team November 16, 2022 12:58
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 91.00% // Head: 91.09% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (f1d1213) compared to base (cc1d6ae).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4962      +/-   ##
============================================
+ Coverage     91.00%   91.09%   +0.08%     
- Complexity     4840     4847       +7     
============================================
  Files           546      546              
  Lines         14447    14447              
  Branches       1395     1396       +1     
============================================
+ Hits          13148    13160      +12     
+ Misses          893      888       -5     
+ Partials        406      399       -7     
Impacted Files Coverage Δ
...opentelemetry/opentracingshim/SpanBuilderShim.java 93.79% <100.00%> (+4.65%) ⬆️
...ava/io/opentelemetry/opentracingshim/SpanShim.java 90.26% <100.00%> (+1.76%) ⬆️
...y/exporter/internal/marshal/CodedOutputStream.java 71.00% <0.00%> (+1.18%) ⬆️
...metry/sdk/metrics/export/PeriodicMetricReader.java 90.00% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carlosalberto
Copy link
Contributor Author

Anything else needed to have this PR merged?

@jkwatson jkwatson merged commit 41c5fbc into open-telemetry:main Nov 24, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTracing Shim: Proper handle tag/attribute ERROR
4 participants