-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing createTracerShim function #4988
Conversation
Signed-off-by: Cuichen Li <cuichli@cisco.com>
Codecov ReportBase: 91.24% // Head: 91.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4988 +/- ##
============================================
- Coverage 91.24% 91.23% -0.02%
+ Complexity 4886 4882 -4
============================================
Files 552 552
Lines 14440 14422 -18
Branches 1379 1375 -4
============================================
- Hits 13176 13158 -18
Misses 876 876
Partials 388 388
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
PTAL @carlosalberto, thanks! |
So sorry, somehow I missed this PR :( I'm fine with adding this overload - that being said, the related issue is about specifically adding:
|
thanks @carlosalberto , i have updated accordingly |
@cuichenli Thanks a lot! |
* add missing createTracerShim function Signed-off-by: Cuichen Li <cuichli@cisco.com> * update based on comment Signed-off-by: Cuichen Li <cuichli@cisco.com>
fix #4909