Attribute assertions should always contain the attr key #5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.24% // Head: 91.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5027 +/- ##
============================================
+ Coverage 91.24% 91.25% +0.01%
+ Complexity 4886 4881 -5
============================================
Files 552 552
Lines 14440 14424 -16
Branches 1379 1375 -4
============================================
- Hits 13176 13163 -13
+ Misses 876 875 -1
+ Partials 388 386 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jkwatson
reviewed
Dec 9, 2022
sdk/testing/src/test/java/io/opentelemetry/sdk/testing/assertj/AttributeAssertionTest.java
Outdated
Show resolved
Hide resolved
jack-berg
approved these changes
Dec 9, 2022
sdk/testing/src/test/java/io/opentelemetry/sdk/testing/assertj/AttributeAssertionTest.java
Outdated
Show resolved
Hide resolved
…/AttributeAssertionTest.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java
that referenced
this pull request
Dec 30, 2022
…ry#5027) * improve attribute assertions to alwyas contain the attr key * spotless * change assertion * Update sdk/testing/src/test/java/io/opentelemetry/sdk/testing/assertj/AttributeAssertionTest.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> * fix build Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5025