Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make closing scope idempotent and noop when different context is active #5061

Merged
merged 3 commits into from
Dec 29, 2022

Conversation

lmolkova
Copy link
Contributor

Fixes #5055

@lmolkova lmolkova requested a review from a team December 22, 2022 03:38
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 91.22% // Head: 91.22% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (87df144) compared to base (4cf3f65).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5061   +/-   ##
=========================================
  Coverage     91.22%   91.22%           
- Complexity     4877     4881    +4     
=========================================
  Files           553      553           
  Lines         14402    14454   +52     
  Branches       1375     1380    +5     
=========================================
+ Hits          13138    13186   +48     
- Misses          878      879    +1     
- Partials        386      389    +3     
Impacted Files Coverage Δ
...entelemetry/context/ThreadLocalContextStorage.java 91.66% <100.00%> (+2.19%) ⬆️
...metry/sdk/metrics/export/PeriodicMetricReader.java 87.14% <0.00%> (-2.86%) ⬇️
...telemetry/sdk/trace/export/BatchSpanProcessor.java 92.41% <0.00%> (-0.69%) ⬇️
.../opentelemetry/exporter/prometheus/Serializer.java 88.33% <0.00%> (+1.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 19e2ce0 into open-telemetry:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close scope is not idempotent
4 participants