Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OTLP User-Agent spaces with dashes #5080

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jack-berg
Copy link
Member

Apparently spaces aren't allowable characters in the <product> portion of the User-Agent. See opentelemetry-specification#3052.

@jack-berg jack-berg requested a review from a team January 4, 2023 17:35
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 91.06% // Head: 91.07% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b4f0696) compared to base (76f7a96).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5080      +/-   ##
============================================
+ Coverage     91.06%   91.07%   +0.01%     
  Complexity     4888     4888              
============================================
  Files           553      553              
  Lines         14453    14453              
  Branches       1381     1381              
============================================
+ Hits          13161    13163       +2     
+ Misses          895      894       -1     
+ Partials        397      396       -1     
Impacted Files Coverage Δ
...elemetry/exporter/internal/otlp/OtlpUserAgent.java 80.00% <100.00%> (ø)
...metry/sdk/metrics/export/PeriodicMetricReader.java 90.00% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit a0f4647 into open-telemetry:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants