Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote exponential histogram data interfaces to stable package #5120

Merged

Conversation

jack-berg
Copy link
Member

Exponential histograms have been marked stable 🎉!

This PR moves the data model interfaces to io.opentelemetry.sdk.metrics.data, the first in a series of steps for metrics to be stable in the java SDK.

@jack-berg jack-berg requested a review from a team January 13, 2023 22:50
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 91.03% // Head: 91.03% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b6ceb73) compared to base (e9c38b6).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5120      +/-   ##
============================================
- Coverage     91.03%   91.03%   -0.01%     
+ Complexity     4875     4873       -2     
============================================
  Files           549      547       -2     
  Lines         14437    14434       -3     
  Branches       1390     1390              
============================================
- Hits          13143    13140       -3     
  Misses          894      894              
  Partials        400      400              
Impacted Files Coverage Δ
.../metrics/ExponentialHistogramBucketsMarshaler.java 100.00% <ø> (ø)
...etrics/ExponentialHistogramDataPointMarshaler.java 100.00% <ø> (ø)
...al/otlp/metrics/ExponentialHistogramMarshaler.java 100.00% <ø> (ø)
.../opentelemetry/exporter/prometheus/Serializer.java 86.68% <0.00%> (ø)
.../aggregator/DoubleExponentialHistogramBuckets.java 83.33% <ø> (ø)
...l/aggregator/ExponentialHistogramAccumulation.java 100.00% <ø> (ø)
...l/data/ImmutableExponentialHistogramPointData.java 100.00% <ø> (ø)
...sdk/metrics/internal/data/ImmutableMetricData.java 100.00% <ø> (ø)
.../io/opentelemetry/sdk/metrics/data/MetricData.java 81.81% <33.33%> (-7.66%) ⬇️
...xporter/internal/otlp/metrics/MetricMarshaler.java 93.61% <100.00%> (-0.14%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit c427bf2 into open-telemetry:main Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants