Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parentbased_jaeger_remote sampler. #5123

Merged

Conversation

fsalvini
Copy link
Contributor

This PR enables support for parentbased_jaeger_remote sampler that is documented in the spec but cannot be instantiated.

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Base: 91.06% // Head: 91.13% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (47ae025) compared to base (50e7a17).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5123      +/-   ##
============================================
+ Coverage     91.06%   91.13%   +0.06%     
- Complexity     4885     4905      +20     
============================================
  Files           553      549       -4     
  Lines         14463    14501      +38     
  Branches       1388     1391       +3     
============================================
+ Hits          13171    13215      +44     
+ Misses          895      890       -5     
+ Partials        397      396       -1     
Impacted Files Coverage Δ
...sdk/autoconfigure/TracerProviderConfiguration.java 100.00% <100.00%> (ø)
...pentelemetry/opentracingshim/ScopeManagerShim.java 94.11% <0.00%> (-0.62%) ⬇️
...nfigure/AutoConfiguredOpenTelemetrySdkBuilder.java 97.18% <0.00%> (-0.14%) ⬇️
...ava/io/opentelemetry/opentracingshim/SpanShim.java 91.07% <0.00%> (ø)
...opentelemetry/sdk/metrics/export/MetricReader.java 100.00% <0.00%> (ø)
...opentelemetry/opentracingshim/OpenTracingShim.java 100.00% <0.00%> (ø)
...telemetry/opentracingshim/NoopSpanBuilderShim.java 100.00% <0.00%> (ø)
...try/sdk/testing/junit5/OpenTelemetryExtension.java 100.00% <0.00%> (ø)
...metry/exporter/internal/marshal/MarshalerUtil.java 89.00% <0.00%> (ø)
...ry/exporter/internal/marshal/CodedInputStream.java 63.15% <0.00%> (ø)
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fsalvini fsalvini force-pushed the support_parentbased_jaeger_remote branch from 25487af to 47ae025 Compare January 18, 2023 08:06
@jkwatson jkwatson merged commit f28e0ad into open-telemetry:main Jan 21, 2023
@fsalvini fsalvini deleted the support_parentbased_jaeger_remote branch January 23, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants