Add resource assertion methods to SpanDataAssert and MetricAssert #5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.00% // Head: 91.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5160 +/- ##
============================================
+ Coverage 91.00% 91.13% +0.12%
+ Complexity 4899 4885 -14
============================================
Files 549 549
Lines 14538 14420 -118
Branches 1393 1380 -13
============================================
- Hits 13230 13141 -89
+ Misses 906 889 -17
+ Partials 402 390 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
reviewed
Feb 2, 2023
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/SpanDataAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/SpanDataAssert.java
Outdated
Show resolved
Hide resolved
Donnerbart
force-pushed
the
improvement/add-resource-assertions-to-spandataassert
branch
3 times, most recently
from
05914cb
to
eccc93c
Compare
Donnerbart
force-pushed
the
improvement/add-resource-assertions-to-spandataassert
branch
2 times, most recently
from
46d4e9f
to
4ad1559
Compare
Donnerbart
changed the title
jack-berg
approved these changes
Feb 9, 2023
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/ResourceAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/ResourceAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/test/java/io/opentelemetry/sdk/testing/assertj/MetricAssertionsTest.java
Outdated
Show resolved
Hide resolved
Donnerbart
force-pushed
the
improvement/add-resource-assertions-to-spandataassert
branch
from
4ad1559
to
fa8c46f
Compare
|
Addressed the PR comments. |
Donnerbart
force-pushed
the
improvement/add-resource-assertions-to-spandataassert
branch
from
fa8c46f
to
8b73cc9
Compare
Donnerbart
force-pushed
the
improvement/add-resource-assertions-to-spandataassert
branch
from
8b73cc9
to
e938c09
Compare
jkwatson
approved these changes
Feb 9, 2023
Donnerbart
deleted the
improvement/add-resource-assertions-to-spandataassert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SpanDataAssertandMetricAssertclasses are missing convenient methods to assert resource attributes. The providedhasResource()quickly reaches its limits when the capturedResourceis populated with (system dependent) autoconfigured values (e.g. host resources).This PR adds a
ResourceAssertclass with methods to assert the resource schema URL and the resource attributes, copying the already established assertion methods from the span attributes.See also https://cloud-native.slack.com/archives/C014L2KCTE3/p1675083869242799