Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semconv to 1.18.0 #5188

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

jack-berg
Copy link
Member

@jkwatson PTAL - would be good to get this late addition in before the release. Not too many changes with this update, luckily.

@jack-berg jack-berg requested a review from a team February 9, 2023 19:46
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 91.07% // Head: 91.05% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (b3c589d) compared to base (43c88b9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5188      +/-   ##
============================================
- Coverage     91.07%   91.05%   -0.03%     
+ Complexity     4868     4867       -1     
============================================
  Files           548      548              
  Lines         14373    14373              
  Branches       1378     1378              
============================================
- Hits          13090    13087       -3     
- Misses          891      892       +1     
- Partials        392      394       +2     
Impacted Files Coverage Δ
...emconv/resource/attributes/ResourceAttributes.java 100.00% <ø> (ø)
...y/exporter/internal/marshal/CodedOutputStream.java 69.59% <0.00%> (-1.17%) ⬇️
...telemetry/sdk/trace/export/BatchSpanProcessor.java 94.48% <0.00%> (-0.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it!

@jack-berg jack-berg merged commit 358ad6c into open-telemetry:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants