Fix autoconfigure shutdown hook #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Feb 15, 2023
.../src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java
Show resolved
Hide resolved
Codecov ReportBase: 91.09% // Head: 91.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5221 +/- ##
=========================================
Coverage 91.09% 91.09%
Complexity 4876 4876
=========================================
Files 549 549
Lines 14420 14421 +1
Branches 1372 1372
=========================================
+ Hits 13136 13137 +1
Misses 891 891
Partials 393 393
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mateuszrzeszutek
approved these changes
Feb 15, 2023
mateuszrzeszutek
approved these changes
Feb 15, 2023
breedx-splk
approved these changes
Feb 15, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
* Fix autoconfigure shutdown hook * Add unit test
jack-berg
added a commit
that referenced
this pull request
Feb 15, 2023
* Fix autoconfigure shutdown hook (#5221) * Fix autoconfigure shutdown hook * Add unit test * Add changelog entry --------- Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> Co-authored-by: Jack Berg <jberg@newrelic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5218.