Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce mTLS support for JaegerRemoteSamplerBuilder (#5209) #5248

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Introduce mTLS support for JaegerRemoteSamplerBuilder (#5209) #5248

merged 1 commit into from
Mar 9, 2023

Conversation

chicobento
Copy link
Contributor

No description provided.

@chicobento chicobento requested a review from a team February 24, 2023 19:00
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 24, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: chicobento / name: Francisco Bento (1f9bbb9)

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (dd40fbe) 90.93% compared to head (fef24d7) 90.96%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5248      +/-   ##
============================================
+ Coverage     90.93%   90.96%   +0.03%     
- Complexity     4887     4890       +3     
============================================
  Files           551      551              
  Lines         14468    14470       +2     
  Branches       1372     1372              
============================================
+ Hits          13156    13163       +7     
+ Misses          914      908       -6     
- Partials        398      399       +1     
Impacted Files Coverage Δ
...ace/jaeger/sampler/JaegerRemoteSamplerBuilder.java 91.66% <100.00%> (+0.49%) ⬆️
...telemetry/sdk/trace/export/BatchSpanProcessor.java 93.79% <0.00%> (-0.69%) ⬇️
...trace/jaeger/sampler/OkHttpGrpcServiceBuilder.java 85.71% <0.00%> (+9.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks!

@jack-berg
Copy link
Member

@chicobento can you sign the CLA?

@chicobento
Copy link
Contributor Author

@jack-berg done

@chicobento
Copy link
Contributor Author

@jack-berg , just rebased and resolved the conflicts

@jack-berg
Copy link
Member

Thanks @chicobento!

@jack-berg jack-berg merged commit 2babc69 into open-telemetry:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants