JaegerRemoteSampler use upstream grpc implementation if ManagedChannel is set #5287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Mar 13, 2023
…y-java into jaeger-remote-sampler-managed-channel
…y-java into jaeger-remote-sampler-managed-channel
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5287 +/- ##
============================================
+ Coverage 90.97% 91.07% +0.10%
+ Complexity 4907 4872 -35
============================================
Files 552 547 -5
Lines 14489 14368 -121
Branches 1372 1356 -16
============================================
- Hits 13181 13086 -95
+ Misses 907 892 -15
+ Partials 401 390 -11
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jkwatson
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the JaegerRemoteSampler uses the upstream gRPC based implementation if
io.grpc.stub.AbstractStubis detected on the classpath. If not, the default OkHttp based implementation is used.This is the last gRPC component to behave like this. A while back, all the other gRPC components switched to only use the upstream gRPC based implementation only if
ManagedChannelis set. Adopting this allows a lot of code to be removed / simplified.If this changed is merged, users who wish to use the upstream gRPC component must:
ManagedChannelwith any required settings since all other builder options are ignored (new requirement)JaegerRemoteSamplerBuilder#setChannel(new requirement)