Logging OTLP sdk dependencies #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-java into logging-otlp-dependencies
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5291 +/- ##
=========================================
Coverage 90.97% 90.97%
Complexity 4907 4907
=========================================
Files 552 552
Lines 14489 14489
Branches 1372 1372
=========================================
Hits 13182 13182
Misses 907 907
Partials 400 400 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mateuszrzeszutek
approved these changes
Mar 27, 2023
jkwatson
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4250.
If someone fields strongly about having one SDK implementation and not the others, they can use gradle to include the unused transitive dependency.
As for the question of whether its appropriate to have a transitive dependency on an alpha artifact, we decided that implementation dependencies are acceptable because users have to "opt-in" to use the alpha surface area by adding their own dependency. We have several examples of this behavior, including :sdk:all.