Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semconv to 1.19.0 and related build tool changes #5311

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

lmolkova
Copy link
Contributor

There were a bunch of breaking changes in the spec in 1.19.0 along with changes in internal yaml structure and signal types.

Spec changes caused build-tool to break (open-telemetry/opentelemetry-specification#3299) and fix requires semconv generation script changes implemented in this PR and shown in open-telemetry/build-tools#157

@lmolkova lmolkova requested a review from a team March 20, 2023 18:14
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (d95bc83) 90.98% compared to head (22f8a17) 90.99%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5311      +/-   ##
============================================
+ Coverage     90.98%   90.99%   +0.01%     
  Complexity     4900     4900              
============================================
  Files           551      551              
  Lines         14484    14494      +10     
  Branches       1369     1369              
============================================
+ Hits          13178    13189      +11     
  Misses          907      907              
+ Partials        399      398       -1     
Impacted Files Coverage Δ
...entelemetry/sdk/trace/data/DelegatingSpanData.java 81.52% <ø> (ø)
...emconv/resource/attributes/ResourceAttributes.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed all the keys and confirm that all are accounted for (i.e. none were erroneously deleted).

Thanks for doing this @lmolkova and for providing the fixes in build-tools!

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lmolkova !

@jkwatson jkwatson merged commit 188210b into open-telemetry:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants