Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark opentracing-shim as stable #5371

Merged
merged 1 commit into from
May 4, 2023

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg requested a review from a team April 11, 2023 18:11
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0a34867) 91.20% compared to head (6692526) 91.20%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5371   +/-   ##
=========================================
  Coverage     91.20%   91.20%           
  Complexity     4866     4866           
=========================================
  Files           546      546           
  Lines         14373    14373           
  Branches       1351     1351           
=========================================
  Hits          13109    13109           
  Misses          875      875           
  Partials        389      389           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carlosalberto
Copy link
Contributor

cc @tylerbenson for an additional review

Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are parts of the code that could use some more comments (for example TracerShim.maybeUnobfuscate. I think the readme could also use a section to document some of the incongruences between the APIs, for example in OTel baggage is immutable.
I don't think these prevent marking it as stable though.

@jack-berg
Copy link
Member Author

@carlosalberto / @jkwatson I think this is ready to go and is low risk given the tiny API surface area, but we lack approvals required to merge for May release.

@carlosalberto
Copy link
Contributor

Thanks for raising this @jack-berg !

@jack-berg jack-berg merged commit a96fd68 into open-telemetry:main May 4, 2023
@jack-berg jack-berg mentioned this pull request Nov 30, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants