Fix flakey JaegerRemoteSamplerGrpcNettyTest #5385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5385 +/- ##
=========================================
Coverage 91.29% 91.29%
Complexity 4879 4879
=========================================
Files 549 549
Lines 14379 14379
Branches 1354 1354
=========================================
Hits 13128 13128
Misses 863 863
Partials 388 388 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test flakes fairly frequently (example). The tests validate the behavior when the server returns various errors, and assert that the default configuration is not updated, and that there are warnings of the errors in the logs. I think the test flakes because the polling interval is low at just 50ms, allowing the sampler to perform a second successful request and update its configuration before the assertions take place. Recreated locally by adding manual
Thread.sleep, and verified this should fix the issue.