Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in autoconfigure-spi module. #5409

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

chukunx
Copy link
Contributor

@chukunx chukunx commented Apr 27, 2023

The parameter name meterProviderCustomizer looks like a typo. Renaming it to loggerProviderCustomizer.

@chukunx chukunx requested a review from a team April 27, 2023 03:40
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 27, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: chukunx / name: chukun (bd52d5e)

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 ⚠️

Comparison is base (6b88f7c) 91.29% compared to head (bd52d5e) 91.27%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5409      +/-   ##
============================================
- Coverage     91.29%   91.27%   -0.03%     
- Complexity     4878     4879       +1     
============================================
  Files           549      549              
  Lines         14379    14388       +9     
  Branches       1354     1354              
============================================
+ Hits          13127    13132       +5     
- Misses          864      869       +5     
+ Partials        388      387       -1     
Impacted Files Coverage Δ
...autoconfigure/spi/AutoConfigurationCustomizer.java 0.00% <ø> (ø)
...logging/otlp/OtlpJsonLoggingLogRecordExporter.java 79.16% <50.00%> (-6.55%) ⬇️
...er/logging/otlp/OtlpJsonLoggingMetricExporter.java 82.75% <50.00%> (-5.71%) ⬇️
...rter/logging/otlp/OtlpJsonLoggingSpanExporter.java 84.00% <50.00%> (-6.91%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chukunx !

@jack-berg jack-berg merged commit 034d65b into open-telemetry:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants