Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus test to reflect new collector behavior #5417

Merged
merged 1 commit into from
May 3, 2023

Conversation

jack-berg
Copy link
Member

Fixes the build. See #5414, #5415, #5416.

Appears that the collector behavior has recently changed.

@jack-berg jack-berg requested a review from a team May 2, 2023 15:09
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (034d65b) 91.29% compared to head (e8c6d9e) 91.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5417   +/-   ##
=========================================
  Coverage     91.29%   91.29%           
  Complexity     4881     4881           
=========================================
  Files           549      549           
  Lines         14388    14388           
  Branches       1354     1354           
=========================================
  Hits          13136    13136           
  Misses          867      867           
  Partials        385      385           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit f4184df into open-telemetry:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants