Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes jaeger remote sampler service strategies bug #5418

Merged
merged 2 commits into from
May 5, 2023

Conversation

DondekarShraddha
Copy link
Contributor

fixes #5407

@jack-berg
Copy link
Member

You'll need to merge main into this branch for the build to pass.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (09ee0d2) 91.29% compared to head (1bddc78) 91.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5418   +/-   ##
=========================================
  Coverage     91.29%   91.29%           
  Complexity     4888     4888           
=========================================
  Files           549      549           
  Lines         14402    14402           
  Branches       1354     1354           
=========================================
  Hits          13148    13148           
  Misses          867      867           
  Partials        387      387           
Impacted Files Coverage Δ
...ce/jaeger/sampler/JaegerRemoteSamplerProvider.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 4af3051 into open-telemetry:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JaegerRemoteSampler service strategies not working
3 participants