Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sdk logs testing #5431

Merged
merged 2 commits into from
May 12, 2023
Merged

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented May 8, 2023

Related to #5340.

@jack-berg jack-berg mentioned this pull request May 8, 2023
7 tasks
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (47ee573) 91.30% compared to head (be4b3bc) 91.31%.

❗ Current head be4b3bc differs from pull request most recent head 842e7b0. Consider uploading reports for the commit 842e7b0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5431   +/-   ##
=========================================
  Coverage     91.30%   91.31%           
- Complexity     4887     4888    +1     
=========================================
  Files           548      547    -1     
  Lines         14404    14404           
  Branches       1353     1353           
=========================================
+ Hits          13152    13153    +1     
+ Misses          867      866    -1     
  Partials        385      385           
Impacted Files Coverage Δ
...metry/sdk/testing/assertj/LogRecordDataAssert.java 100.00% <ø> (ø)
...dk/testing/exporter/InMemoryLogRecordExporter.java 93.33% <ø> (ø)
...ntelemetry/sdk/testing/logs/TestLogRecordData.java 100.00% <ø> (ø)
...y/sdk/testing/assertj/OpenTelemetryAssertions.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg marked this pull request as ready for review May 10, 2023 14:11
@jack-berg jack-berg requested a review from a team May 10, 2023 14:11
@jack-berg jack-berg merged commit d67faf2 into open-telemetry:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants