Add a hasBucketBoundaries() variant that allows specifying precision
#5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5457 +/- ##
============================================
+ Coverage 91.30% 91.34% +0.04%
- Complexity 4887 4892 +5
============================================
Files 547 547
Lines 14404 14410 +6
Branches 1353 1354 +1
============================================
+ Hits 13151 13163 +12
+ Misses 867 864 -3
+ Partials 386 383 -3
☔ View full report in Codecov by Sentry. |
jkwatson
approved these changes
May 16, 2023
jack-berg
reviewed
May 17, 2023
| public HistogramPointAssert hasBucketBoundaries(double[] boundaries, Offset<Double> precision) { | ||
| isNotNull(); | ||
| double[] actualBoundaries = actual.getBoundaries().stream().mapToDouble(d -> d).toArray(); | ||
| Assertions.assertThat(actualBoundaries).as("boundaries").containsExactly(boundaries, precision); |
There was a problem hiding this comment.
Maybe we change the behavior of hasBucketBoundaries(double... boundaries) to include some default reasonable precision.
There was a problem hiding this comment.
👍
How about 0.000001?
jack-berg
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues with double metrics precision in open-telemetry/opentelemetry-java-instrumentation#8490 (comment), figured we might as well add a method varian that allows passing
Offset