Ensure correct compiled output and sources are included in multi version jar #5487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5487 +/- ##
============================================
- Coverage 91.32% 91.31% -0.01%
- Complexity 4890 4891 +1
============================================
Files 547 547
Lines 14410 14410
Branches 1354 1354
============================================
- Hits 13160 13159 -1
- Misses 866 867 +1
Partials 384 384 ☔ View full report in Codecov by Sentry. |
mateuszrzeszutek
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5474.
opentelemetry-sdk-commonpublishes is a multi-version jar. It looks like the sources and javadoc jars incorrectly include compiled class files. This fixes that, including the correct files in each the respective jars.