Add meaningful .toString to NoopLogRecordProcessor and DefaultOpenTelemetry
#5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5493 +/- ##
=========================================
Coverage 91.33% 91.34%
- Complexity 4891 4893 +2
=========================================
Files 547 547
Lines 14410 14412 +2
Branches 1354 1354
=========================================
+ Hits 13161 13164 +3
Misses 865 865
+ Partials 384 383 -1
☔ View full report in Codecov by Sentry. |
iRevive
changed the title
.toString to NoopLogRecordProcessor.toString to NoopLogRecordProcessor and DefaultOpenTelemetry
iRevive
commented
May 31, 2023
|
|
||
| @Override | ||
| public String toString() { | ||
| return "DefaultOpenTelemetry{" |
There was a problem hiding this comment.
Still trying to figure out how that is correct. TracerProvider and MeterProvider are always noop. Should I include them in toString?
There was a problem hiding this comment.
I'd say no. This looks fine to me.
iRevive
force-pushed
the
meaningful-tostring
branch
2 times, most recently
from
52cdc45
to
56de53a
Compare
iRevive
force-pushed
the
meaningful-tostring
branch
from
56de53a
to
7b68022
Compare
jkwatson
approved these changes
May 31, 2023
jack-berg
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small improvement. The behavior is similar to
opentelemetry-java/context/src/main/java/io/opentelemetry/context/propagation/NoopTextMapPropagator.java
Lines 36 to 39 in 93bcdf2